This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 946183 - [fugu]There is some black area in video-recording preview w... #14798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -134,7 +134,7 @@ var Filmstrip = (function() { | |||
| } | |||
|
|
|||
| function hidePreview() { | |||
| Camera.viewfinder.play(); // Restart the viewfinder | |||
| Camera.startPreview(); | |||
There was a problem hiding this comment.
I don't think we need to call Camera.startPreview() here because we use Camera.viewfinder.pause() at show function. If we need to use startPreview, we should also use stopPreview there.
There was a problem hiding this comment.
https://github.com/mozilla-b2g/gaia/pull/14798/files#diff-2d56b71fb19e65f35b4b8b6d5fc625b4R98
Okay, I've changed to stopPreview,thanks.~
…w when it back from video player.
-- scine confirm() will break camera graphic performance so submit this patch for workaround in gaia.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...hen it back from video player.