Bug 855165 - Migrate to new Notification API and close notifications

[lissyx]

No description provided.

[rwaldron]

Does this have to be a string? If not, then it would be preferrable to use an object:

tag: {
   threadId: threadId
}

EDIT

If Notification.get({ tag: ... }) expects a string, then at very least, this string should be: "threadId:" + threadId

[lissyx]

Yes, the spec requires a string: http://notifications.spec.whatwg.org/#api.

[rwaldron]

Sorry, I should've mentioned this before but it slipped my mind until just now: we run make hint APP=sms for all Message app code (this is jshint). I just ran it for this and there are a few bits that need to be addressed:

apps/sms/js/activity_handler.js: line 431, col 38, 'Notification' is not defined.
apps/sms/js/message_manager.js: line 362, col 9, 'Notification' is not defined.
apps/sms/test/unit/activity_handler_test.js: line 6, col 42, 'MockNotificationHelper' is defined but never used.
apps/sms/test/unit/message_manager_test.js: line 564, col 19, 'MockNotification' is not defined.
apps/sms/test/unit/message_manager_test.js: line 569, col 23, 'MockNotification' is not defined.
apps/sms/test/unit/message_manager_test.js: line 664, col 37, 'MockNotification' is not defined.
apps/sms/test/unit/message_manager_test.js: line 684, col 13, 'Notification' is not defined.

In all of these cases, all you need to do is add those identifiers to the /*globals ...*/ list at the top of the appropriate file. These following errors you can ignore, they are being addressed in other tickets:

apps/sms/js/desktop-only/contacts.js: line 11, col 82, Line is too long.
apps/sms/test/marionette/phone_number_service_test.js: line 3, col 5, Redefinition of 'assert'.
apps/sms/test/marionette/phone_number_service_test.js: line 8, col 1, 'marionette' is not defined.
apps/sms/test/marionette/phone_number_service_test.js: line 9, col 16, 'marionette' is not defined.
apps/sms/test/marionette/phone_number_service_test.js: line 40, col 11, 'marionetteScriptFinished' is not defined.
apps/sms/test/marionette/phone_number_service_test.js: line 6, col 24, 'TARGET_APP_MANIFEST' is defined but never used.

Again, sorry for this last minute thing, but appreciate your patience!