This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 961950 - Replace message edit button with option menu contains delete / settings option #15753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
steveck-chung
commented
Jan 28, 2014
steveck-chung
commented
- Replace the original thread edit icon with option icon which will trigger option menu contains thread deletion/ settings / cancel options.
| l10nId: 'settings', | ||
| method: function oSettings() { | ||
| ActivityPicker.openSettings(); | ||
| } |
There was a problem hiding this comment.
Could be directly ActivityPicker.openSettings ?
|
@steveck-chung Steve! Sorry for the delay here... Could you rebase? I would like to re-test again and we are quite close to land this! Thanks!! |
…lete / settings option
borjasalguero
added a commit
that referenced
this pull request
Feb 17, 2014
Bug 961950 - Replace message edit button with option menu contains delete / settings option
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.