This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 964722 - Refactor and reenable test_dialer_add_contact.py for deskto... #15765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ktop and device r=bebe
|
|
||
| # Switch back to keypad-view | ||
| self.wait_for_condition(lambda m: self.apps.displayed_app.name == self.phone.name) |
There was a problem hiding this comment.
Why was this wait removed? Is something like this present in another method thus making it redundant?
There was a problem hiding this comment.
This wait actually always resolved to True so it was redundant!
When the Phone app opens Contacts it's still in Phone app, technically speaking.
bebef1987
added a commit
that referenced
this pull request
Jan 29, 2014
Bug 964722 - Refactor and reenable test_dialer_add_contact.py for desktop and device r=bebe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...p and device r=bebe