Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Bug 969587 - Run variant customization with no icc #16097

Merged
merged 2 commits into from Feb 12, 2014
Merged

Bug 969587 - Run variant customization with no icc #16097

merged 2 commits into from Feb 12, 2014

Conversation

qdot
Copy link
Contributor

@qdot qdot commented Feb 8, 2014

No description provided.

var mcc = IccHelper.iccInfo ? IccHelper.iccInfo.mcc : undefined;
var mnc = IccHelper.iccInfo ? IccHelper.iccInfo.mnc : undefined;
var mcc = undefined;
var mnc = undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just init these to 000 and 000 and move the comment up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't use 000-000 by default here, because that means in the case that the SIM is present but not yet ready, we'll always customize to the default mnc/mcc settings. We want to wait for sim to be ready when icchelper and sim are available. That said, we can also do a cardstate check, and if the cardstate comes back as absent, just configure for the default 000-000 pair.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok actually I split the difference. If there's no sim present, that will show up in the ICC card state and we can set to the default. If there's no iccHelper at ALL, we can do similar. Otherwise, we assume the SIM is present but just not ready and can continue to wait. This brings up interesting questions about the SIM lock affecting ICC info fetching, but that can be handled elsewhere if need be.

qdot added a commit that referenced this pull request Feb 12, 2014
Bug 969587 - Run variant customization with no icc
@qdot qdot merged commit 3999923 into mozilla-b2g:master Feb 12, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants