This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 972160 - Run specific marionette tests for multiple times on Travis. #16244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -603,7 +603,6 @@ define run-js-command | |||
| endef | |||
|
|
|||
| define run-node-command | |||
| echo "run-node-command $1"; | |||
There was a problem hiding this comment.
Could I ask why we must keep this line?
If we keep this line, we could not get a "clear" return value of a node command.
For example, if we would like to store the return value of doing @$(call run-node-command, pull-request-marionette-test) in a variable in a bash script, we will get run-node-command pull-request-marionette-test path/to/a_test.js path/to/b_test.js.
It might be not good to reuse. How do you think?
|
Main commit: evanxd@acedca6 |
| @@ -28,6 +29,7 @@ matrix: | |||
| allow_failures: | |||
| - env: CI_ACTION=unit-tests-in-b2g | |||
| - env: CI_ACTION=unit-tests-coverage | |||
| - env: CI_ACTION=marionette_js_check | |||
There was a problem hiding this comment.
I think we could let it in allow_failures area first.
Make sure this action is stable, then we could move to must pass area.
How do you think?
evanxd
added a commit
that referenced
this pull request
Feb 17, 2014
Bug 972160 - Run specific marionette tests for multiple times on Travis.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You could check-pick the it and change any marionette test file to trigger 30 times running in CI_ACTION=marionette_js_check on Travis.