This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 974292 - [Email][V1.3&V1.4] Tapping the Done button of mail settings page redirects to a blank page #16464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngs page redirects to a blank page
jrburke
added a commit
that referenced
this pull request
Feb 21, 2014
Bug 974292 - [Email][V1.3&V1.4] Tapping the Done button of mail settings page redirects to a blank page r=asuth
jrburke
added a commit
that referenced
this pull request
Feb 24, 2014
Bug 974292 - [Email][V1.3&V1.4] Tapping the Done button of mail settings page redirects to a blank page r=asuth
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a side effect of this change:
f1053cc#diff-3
where
Cards.removeCardAndSuccessors(this.domNode, 'animate', 1);was changed toCards.removeCardAndSuccessors(this.domNode, 'animate');By leaving out the "how many cards" it meant "this card and all cards after it". However, since the folder_picker is added before message_list in the stack, it means that all the account cards are inserted between folder_picker and message_list. So when the removeCardAndSuccessors removed the progress card, it also removed message_list.
Restoring the 1 arg fixes it. I apologize for letting this slip past before, as I had it in my head that removeCardAndSuccessors defaulted to just that one card if no arg so I did not comment on it when I saw the change.