Bug 948472 - Test for Bug 938219: "add to an existing contact" activity #16835

bebef1987 · 2014-03-04T17:16:37Z

No description provided.

zacc · 2014-03-05T09:50:01Z

tests/python/gaia-ui-tests/gaiatest/apps/messages/regions/message_thread.py

    def tap_header(self):
        self.wait_for_element_displayed(*self._message_header_locator)
        self.marionette.find_element(*self._message_header_locator).tap()

+        from gaiatest.apps.system.regions.activities import Activities
+        return Activities(self.marionette, switch_frame=False)


It's kind of confusing but there's already another Activities region at gaiatest.apps.messages.regions.activities

I would remove that class and the confusion and use the main system activities class
@zacc ?

I thought about it and I thought it was a bit confusing to have one System class that's not actually operating in the system so I think we should reuse the region in messages/region/activities.py

viorelaioia-zz · 2014-03-07T17:00:33Z

LGTM now, the test runs nice on device :)

zacc · 2014-03-14T16:16:37Z

tests/python/gaia-ui-tests/gaiatest/apps/contacts/regions/contact_form.py

@@ -143,12 +143,13 @@ def __init__(self, marionette):
        update = self.wait_for_element_present(*self._update_locator)
        self.wait_for_condition(lambda m: update.location['y'] == 0)

-    def tap_update(self):
+    def tap_update(self, switch_to_contact_details=True):


I just noticed that in this class we already have a method that has return_details. Let's make them the same, for consistency.

@zacc which method? the only other place we return details is in the tap_cancel method but that's not used in our test

Sorry my mistake, it's in the parent to this (Contacts class): tap(return_details=False)

I don't like this because switch_to reminds me of switch to frame, but this doesn't do that. so let's use return_details which is more consistent.

chirarobert · 2014-04-01T13:04:31Z

I ran the test locally and it failed once with the following error:

Traceback (most recent call last):
  File "/home/robertchira/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/marionette_test.py", line 163, in run
    testMethod()
  File "/home/robertchira/workspace/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_add_to_an_existing_contact_from_messages.py", line 49, in test_sms_add_number_to_existing_contact
    self.wait_for_condition(lambda m: self.message_thread.header_text == self.contact['name'])
  File "/home/robertchira/workspace/gaia/tests/python/gaia-ui-tests/gaiatest/gaia_test.py", line 1043, in wait_for_condition
    Wait(self.marionette, timeout).until(method, message=message)
  File "/home/robertchira/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/wait.py", line 143, in until
    cause=last_exc)
TimeoutException: TimeoutException: Timed out after 30.098954916 seconds
TEST-UNEXPECTED-FAIL | test_add_to_an_existing_contact_from_messages.py test_add_to_an_existing_contact_from_messages.TestSmsAddToExistingContact.test_sms_add_number_to_existing_contact | 
----------------------------------------------------------------------
Ran 1 test in 109.417s

I was not watching the device when the error occurred so I'm not sure what happened. Maybe start an adhoc run with the test and see if it is reproduced.

bebef1987 · 2014-04-24T12:47:51Z

Updated

zacc · 2014-04-24T14:16:28Z

tests/python/gaia-ui-tests/gaiatest/apps/messages/regions/message_thread.py

    def tap_header(self):
        self.wait_for_element_displayed(*self._message_header_locator)
        self.marionette.find_element(*self._message_header_locator).tap()

+        from gaiatest.apps.messages.regions.activities import Activities
+        return Activities(self.marionette)


I think tap_call below this should be moved into the activities region if you make this change. but funcitonally it's OK without it.

this should be done in a different task
we don't use this method in my test and moving it would affect other tests

chirarobert · 2014-04-28T07:16:10Z

lgtm

bobsilverberg · 2014-05-05T18:40:38Z

tests/python/gaia-ui-tests/gaiatest/apps/messages/regions/message_thread.py

@@ -35,10 +35,21 @@ def received_messages(self):
    def all_messages(self):
        return [Message(self.marionette, message) for message in self.marionette.find_elements(*self._all_messages_locator)]

+    def wait_for_message_header_visible(self):


Why are we bothering to define a method for this that is only used once in header_text? Why not just put self.wait_for_element_displayed(*self._message_header_locator) as the first line in header_text()?

good point done

bobsilverberg · 2014-05-05T18:48:31Z

The test works well. Just a few comments in the PR.

viorelaioia-zz · 2014-05-22T13:06:49Z

...ui-tests/gaiatest/tests/functional/messages/test_add_to_an_existing_contact_from_messages.py

+    def test_sms_add_number_to_existing_contact(self):
+
+        # open the message thread screen
+        self.message_thread = self.messages.tap_first_received_message()


This is the first message in the list, it can be either the first received message, or the first sent one. We should rename this method to tap_first_message().
But, as it is used in some other test too(https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_to_dialer.py#L30), maybe it is better to leave it as it is for now.

viorelaioia-zz · 2014-05-22T13:24:32Z

Besides the extra space, lgtm

AndreiH · 2014-05-27T13:55:05Z

Test that fails on Travis is not related to this pull

Bug 948472 - Test for Bug 938219: "add to an existing contact" activity

zacc reviewed Mar 5, 2014
View reviewed changes

zacc reviewed Mar 14, 2014
View reviewed changes

zacc reviewed Apr 24, 2014
View reviewed changes

bobsilverberg reviewed May 5, 2014
View reviewed changes

viorelaioia-zz reviewed May 22, 2014
View reviewed changes

Bug 948472 - Test for Bug 938219: "add to an existing contact" activity

0bd0d85

AndreiH pushed a commit that referenced this pull request May 27, 2014

Merge pull request #16835 from bebef1987/sms_contact

75bf3cb

Bug 948472 - Test for Bug 938219: "add to an existing contact" activity

AndreiH merged commit 75bf3cb into mozilla-b2g:master May 27, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 948472 - Test for Bug 938219: "add to an existing contact" activity #16835

Bug 948472 - Test for Bug 938219: "add to an existing contact" activity #16835

bebef1987 commented Mar 4, 2014

zacc Mar 5, 2014

bebef1987 Mar 5, 2014

zacc Mar 6, 2014

viorelaioia-zz commented Mar 7, 2014

zacc Mar 14, 2014

bebef1987 Mar 26, 2014

zacc Apr 28, 2014

bebef1987 May 22, 2014

chirarobert commented Apr 1, 2014

bebef1987 commented Apr 24, 2014

zacc Apr 24, 2014

bebef1987 Apr 25, 2014

chirarobert commented Apr 28, 2014

bobsilverberg May 5, 2014

bebef1987 May 22, 2014

bobsilverberg commented May 5, 2014

viorelaioia-zz May 22, 2014

viorelaioia-zz commented May 22, 2014

AndreiH commented May 27, 2014

Bug 948472 - Test for Bug 938219: "add to an existing contact" activity #16835

Bug 948472 - Test for Bug 938219: "add to an existing contact" activity #16835

Conversation

bebef1987 commented Mar 4, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

viorelaioia-zz commented Mar 7, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chirarobert commented Apr 1, 2014

bebef1987 commented Apr 24, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chirarobert commented Apr 28, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bobsilverberg commented May 5, 2014

Choose a reason for hiding this comment

viorelaioia-zz commented May 22, 2014

AndreiH commented May 27, 2014