Bug 969525 - Wrong message exporting contacts with USBStorage enabled #17657
Conversation
| exportSDOption.querySelector('p').textContent = | ||
| _(exportSDErrorMessage); | ||
| // update the message | ||
| navigator.mozL10n.localize(importSDOption.querySelector('p.error-message'), |
There was a problem hiding this comment.
why are we calling here the localize method instead of using the standard '_' . Please use the same code I provided you in my shared commit jmcanterafonseca@7766fd2#diff-45d80111ee5f57643b5a8a07aac2daa9R384
If you need that for test passing you can always create an spy over the '_' method
thanks
There was a problem hiding this comment.
after talking with l10n localizers, they recommend using the mozL10n.localize function instead of '_' code.
We need to change it eventually, but if you rather to use the same for now, I can leave the change for another bug.
|
general comment about the tests: can we structure the tests by having a test suite called 'sdCardAvailability' indepedent of import or export. That approach will make tests clearer, simpler and with less lines of code. All in all we are testing settings no import or export themselves |
Fixed: - Rewrite updateStorageOptions function for better readability - Got rid of Settings dependency - Tests added for export, fixed for import
Bug 969525 - Wrong message exporting contacts with USBStorage enabled (r=jmcf)
Fixed: