This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 967785 update fxa landing image #18608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At risk of complicating this branch and PR a bit, I've added two additional commits which make more minor CSS changes, this time related to an envelope icon, in Settings and System. Once again, I've split them out into separate commits. |
|
I'll upload some before and after screenshots for each of the relevant changes, to make it clearer just what has been changed. |
|
987785 (Firefox image), System app: before: after: |
|
987785 (Firefox image), Settings app: before: after: |
|
987785 (Firefox image), FTE app: before: after: |
|
And here is bug 987783 (envelope image), Settings app: before: after: |
|
Finally, bug 987783 (envelope image), System app: before: after: |
…,arthurcc
* Update image in FxA System app 'enter email' landing screen.
* Update image in FTE FxA panel.
* Add image to FxA Settings panel logged-out state.
* Also fix bug 967783: add final FxA envelope image to Settings, System.
* Remove flat fox styles from System app, to be replaced with a TBD icon
in bug 967779.
jaredhirsch
added a commit
that referenced
this pull request
Apr 30, 2014
Bug 967785 update fxa landing image
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects three different apps, so opening as one PR with three reviewers.
Updating the landing pages in system, FTE, and settings to match the spec, replacing the "firefox icon in a cloud" image with just a firefox image.