This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1000496 - [B2G][Clock]Deleting an alarm then killing the clock app a... #18613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p and relaunching it causes the deleted alarm to reappear.
| @@ -293,7 +293,7 @@ define(function(require, exports, module) { | |||
| window.dispatchEvent(new CustomEvent('alarm-removed', { | |||
| detail: { alarm: this } | |||
| })); | |||
| callback(err, this); | |||
| callback && callback(err, this); | |||
There was a problem hiding this comment.
I find it cleaner like:
if (callback) {
callback(err, this);
}but since this pattern is also used on save I'm OK with it. - it's following the current code convention.
There was a problem hiding this comment.
I'm actually a huge fan of the cb && cb() style, for callbacks at least. Callbacks have a unique set of constraints that, in my opinion, make the shorthand worthwhile: They are everywhere, they are almost always optional, and you aren't really conditionally doing something so you don't have to think too hard about what happens with the &&. So you're saving at least two lines in exchange for an idiom that, when applied mainly to callbacks, is simple to read and rationalize about.
mcav
added a commit
that referenced
this pull request
Apr 25, 2014
Bug 1000496 - [B2G][Clock]Deleting an alarm then killing the clock app a... r=millermedeiros
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...nd relaunching it causes the deleted alarm to reappear.