This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 995128 - Suggestion list should use the building block action menu #18730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rik
commented
Apr 28, 2014
rik
commented
- Move the suggestion-item to an HTML import
- Prefix all classes used for JS DOM selection
- Remove the transition when the overlay opens since it was not visible on device
- Reorganise the test file to separate SuggestionBar and SuggestionList tests
- Add some new tests
- Move suggestion bar related styles out of keypad.css
- Used the BEM syntax for classes
| background: url(keypad/images/icon_arrow_white.png) no-repeat right 0.3rem bottom / 1rem; | ||
| } | ||
|
|
||
| #suggestion-bar > .suggestion-item { |
There was a problem hiding this comment.
don't know how this was speced but it looks a bit weird highlighted
- Move the suggestion-item to an HTML import - Prefix all classes used for JS DOM selection - Remove the transition when the overlay opens since it was not visible on device - Reorganise the test file to separate SuggestionBar and SuggestionList tests - Add some new tests - Move suggestion bar related styles out of keypad.css - Used the BEM syntax for classes
rik
added a commit
that referenced
this pull request
May 21, 2014
Bug 995128 - Suggestion list should use the building block action menu r=etienne
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.