This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1020109 - Cell broadcast search list is not set correctly. r=arthurcc #19989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code attempts to protect against empty objects incorrectly since empty arrays are truthy in JavaScript. The result is empty objects get passed to SettingsLock.set() which seems to break all subsequent settings change observers.
ksimons
changed the title
sergi
added a commit
that referenced
this pull request
Jun 16, 2014
Bug 1020109 - Cell broadcast search list is not set correctly. r=arthurcc
sergi
added a commit
that referenced
this pull request
Jun 17, 2014
Bug 1020109 - Cell broadcast search list is not set correctly. r=arthurcc
sergi
added a commit
that referenced
this pull request
Jun 17, 2014
Bug 1020109 - Cell broadcast search list is not set correctly. r=arthurcc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code attempts to protect against empty objects incorrectly
since empty arrays are truthy in JavaScript. The result is empty objects
get passed to SettingsLock.set() which seems to break all subsequent
settings change observers.