Bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen #20054
Conversation
| @@ -439,8 +443,79 @@ var CallScreen = { | |||
| } | |||
| }, | |||
|
|
|||
| /** | |||
| * Code 'inspired in' | |||
There was a problem hiding this comment.
Instead of a big copy/paste, can we have shared code for this? With some parameters. @snowmantw what do you thnk?
There was a problem hiding this comment.
If we have only one function to share, and the main purpose of this is to update some specific UI elements, it may be difficult to isolate this function and make it general enough to become a shared library. However, I support to reduce copy/paste in our code base. I just don't know how to do that in this case.
There was a problem hiding this comment.
We are already sharing lockscreen_slide.js and screen_layout.js. So we should be able to share this too.
There was a problem hiding this comment.
Sharing code included in the forthcoming version of the patch ;)
|
Continuous Integration started. Results |
| opacity: 0; | ||
| transition: opacity 0.3s linear; | ||
| } | ||
|
|
||
| #main-container { |
There was a problem hiding this comment.
Fixed ;) Thanks!
|
Continuous Integration started. Results |
| @@ -147,13 +152,12 @@ | |||
|
|
|||
| colors: { | |||
| left: { | |||
| touchedColor: '0, 170, 204', | |||
| touchedColorStop: '178, 229, 239' | |||
| touchedColor: '255, 255, 255', | |||
There was a problem hiding this comment.
Are your sure you need to change these default properties? I've designed these properties can be overwritten while you initialize it in your component, like System/js/lockscreen.js or the callscreen . Unless the properties really can't satisfied your needs, please don't change them, or at least make them customizable and customize them in your component.
|
Continuous Integration started. Results |
|
Continuous Integration started. Results |
|
Continuous Integration started. Results |
|
Continuous Integration started. Results |
|
Continuous Integration started. Results |
|
Continuous Integration started. Results |
|
Continuous Integration started. Results |
|
Continuous Integration started. Results |
…nts of the VR call screen when in lockscreen
|
|
Germán Toro del Valle (gtorodelvalle)
…ockscreen-visual-refresh-reloaded Bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen
No description provided.