This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Bug 1016233 - [Collections App] Collection UI styling #20056
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,43 +1,70 @@ | ||
body { | ||
background: #000000; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ranbena will be useful to move this to |
||
gaia-grid { | ||
display: block; | ||
height: 100%; | ||
width: 100%; | ||
} | ||
|
||
#bgimage { | ||
position: fixed; | ||
#header { | ||
height: 5.4rem; | ||
line-height: 5.4rem; | ||
color: #ffffff; | ||
font-size: 2.25rem; | ||
overflow: hidden; | ||
background-position: center -2.4rem; /* to continue wallpaper position from status bar */ | ||
position: relative; | ||
} | ||
#header:after { | ||
position: absolute; | ||
content: ' '; | ||
z-index: 0; | ||
background-color: rgba(0,0,0,0.8); | ||
top: 0; | ||
left: 0; | ||
right: 0; | ||
bottom: 0; | ||
} | ||
#name { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: i would prefer line breaks between rules. |
||
margin-right: 1rem; | ||
padding-left: 3rem; | ||
display: block; | ||
position: relative; | ||
z-index: 1; | ||
overflow: hidden; | ||
white-space: nowrap; | ||
mask: url('../images/app_name_mask.svg#fade_right_mask'); | ||
text-overflow: ''; | ||
-moz-box-sizing: border-box; | ||
} | ||
#close { | ||
position: absolute; | ||
background: transparent url('../images/close.png') no-repeat 50% 50%/1.7rem; | ||
left: 0; | ||
top: 0; | ||
width: 3rem; | ||
height: 5.4rem; | ||
z-index: 1; | ||
} | ||
#content { | ||
border-top: 0.1rem solid #555; | ||
position: fixed; | ||
top: 5.4rem; | ||
left: 0; | ||
z-index: -1; | ||
right: 0; | ||
bottom: 0; | ||
overflow: scroll; | ||
padding-top: 2.4rem; | ||
background-color: #000000; | ||
background-size: cover; | ||
} | ||
|
||
#bgimage:after { | ||
#content:after { | ||
position: fixed; | ||
top: 0; | ||
top: 5.4rem; | ||
left: 0; | ||
width: 100%; | ||
height: 100%; | ||
z-index: 0; | ||
content: " "; | ||
background-color: rgba(0,0,0,0.4); | ||
} | ||
|
||
#header { | ||
height: 5rem; | ||
background: #ccc; | ||
font-size: 2rem; | ||
} | ||
#name { | ||
font-weight: bold; | ||
} | ||
#close { | ||
float: right; | ||
color: white; | ||
} | ||
|
||
#content { | ||
position: relative; | ||
} |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just an idea - does the homescreen already have a reference to the bg image? if it does, we can pass it in
activity.data
and save time getting the wallpaper from settingsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea. Especially seeing how it takes time to load the image.
Still, I'd defer this for now.