Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Bug 989927 - [Contacts][Refactor] Create a library that reads the Global... #20423

Merged

Conversation

jmcanterafonseca
Copy link
Contributor

... Contacts DataStore and provide a single contact

dsList.forEach(function(aDs) {
datastores[aDs.owner] = aDs;
});
datastores[MOZ_CONTACTS_OWNER] = new MozContactsDatastore();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is transitional, we should mark it with the bug number that will solve this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh absolutely

@arcturus
Copy link
Contributor

At the begining wasn't sure if adding the dependency of ther merger was right or not, sounds to me that there is a lot of code done (everything) that is reausable, and we have well separated the merging without any FB dependency so, does like a good option.

One thing that would like to do, perhaps not in this PR, but as a follow up is reduce the number of lines of the method mergeAll currently almost 200 lines and with a high cyclomatic complexity, was wondering if we could split that in the same way that we render a contact details, we have specific functions for each of the fields, perhaps it sounds over killing but will be nicer to read and maintain in the fture.

…bal Contacts DataStore and provide a single contact
@try-server-hook
Copy link

Continuous Integration started. Results

jmcanterafonseca added a commit that referenced this pull request Jun 16, 2014
Bug 989927 - [Contacts][Refactor] Create a library that reads the Global...
@jmcanterafonseca jmcanterafonseca merged commit eac1340 into mozilla-b2g:master Jun 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants