This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1039984 - [System] Trying to open a smartcollection after killing th... #21862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Salvador de la Puente González (lodr)
| @@ -392,7 +392,9 @@ | |||
| return; | |||
| } | |||
|
|
|||
| this._killed = true; | |||
| if (!this.isHomescreen) { | |||
There was a problem hiding this comment.
Could you tell me why this is added?
There was a problem hiding this comment.
Yeah, that doesn't seem right to me either...
… the Homescreen do nothing. Allow Homescreen application window to be killed as other windows. But avoiding to be marked as _killed as, from a system app perspective, the homescreen is never killed.
|
|
delapuente
added a commit
that referenced
this pull request
Jul 21, 2014
…homescreen Bug 1039984 - [System] Trying to open a smartcollection after killing th...
delapuente
added a commit
that referenced
this pull request
Jul 22, 2014
…homescreen Bug 1039984 - [System] Trying to open a smartcollection after killing th...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...e Homescreen do nothing.
Allow Homescreen application window to be killed as other windows.