This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1054234 - Search app should not show blacklist apps #23130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sherman Chen (shamenchens)
| blacklist.forEach(function(blackentry) { | ||
| for (var i in appListing) { | ||
| var app = appListing[i]; | ||
| if (app.launch_path === blackentry) { |
There was a problem hiding this comment.
The fact that we use launch path for this is concerning as many launch paths are only index.html. I don't think it's a good thing to have in the codebase for a long time.
shamenchens
force-pushed
the
Bug1054234-SearchBlacklistApp-5
branch
from
f4477ce
to
3fe103b
Compare
|
|
shamenchens
added a commit
that referenced
this pull request
Aug 22, 2014
…App-5 Bug 1054234 - Search app should not show blacklist apps, r=kgrandon
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.