Bug 1055198 - [Video] Hide soft home key during full screen video playba... #23500

russnicoletti · 2014-08-29T18:08:59Z

...ck

try-server-hook · 2014-08-29T18:09:45Z

try-server-hook · 2014-08-29T19:47:58Z

punamdahiya · 2014-09-02T20:14:54Z

shared/style/confirm.css

+  }
+}
+
+
 form[role="dialog"][data-type="confirm"] menu button::-moz-focus-inner {


We should move this check inside video.css as this will impact other apps such as gallery using confirm.css

try-server-hook · 2014-09-03T02:04:53Z

russnicoletti started tests. Results

try-server-hook · 2014-09-03T21:38:52Z

russnicoletti started tests. Results

try-server-hook · 2014-09-03T22:19:32Z

russnicoletti started tests. Results

try-server-hook · 2014-09-03T22:26:35Z

russnicoletti started tests. Results

punamdahiya · 2014-09-04T16:54:46Z

apps/video/index.html

@@ -192,7 +192,7 @@ <h1 id="overlay-title"></h1>
      <section>


We should add class="software-home-button" on menu at Line 187, that will be needed for the 'Add videos to get started' and related overlay shown

try-server-hook · 2014-09-04T17:47:30Z

russnicoletti started tests. Results

try-server-hook · 2014-09-10T20:36:29Z

russnicoletti started tests. Results

try-server-hook · 2014-09-11T16:01:30Z

russnicoletti started tests. Results

punamdahiya · 2014-09-11T16:36:20Z

apps/video/js/video.js

@@ -9,6 +9,7 @@ const LAYOUT_MODE = {
  selection: 'layout-selection',
  fullscreenPlayer: 'layout-fullscreen-player'
 };
+var foo = 0;



This seems a redundant variable

try-server-hook · 2014-09-17T23:53:27Z

russnicoletti started tests. Results

try-server-hook · 2014-09-18T05:06:36Z

russnicoletti started tests. Results

try-server-hook · 2014-09-26T18:55:35Z

russnicoletti started tests. Results

…yback

try-server-hook · 2014-10-01T20:21:37Z

russnicoletti started tests. Results

mozilla-autolander-deprecated · 2014-10-01T21:51:51Z

This pull request has been closed due to tree stability issues. Please rebase and re-open the pull request if you still need to land this. Ensure the gaia-try run is green before landing. Sorry for any inconvenience.

russnicoletti force-pushed the Bug-1055198 branch from a0f3ee9 to f44cbd0 Compare August 29, 2014 19:47

punamdahiya reviewed Sep 2, 2014
View reviewed changes

russnicoletti force-pushed the Bug-1055198 branch from f44cbd0 to c0395d3 Compare September 3, 2014 02:04

russnicoletti force-pushed the Bug-1055198 branch from c0395d3 to f76713b Compare September 3, 2014 21:38

russnicoletti force-pushed the Bug-1055198 branch from f76713b to 2eda3a6 Compare September 3, 2014 22:18

russnicoletti force-pushed the Bug-1055198 branch from 2eda3a6 to 32d377c Compare September 3, 2014 22:25

punamdahiya reviewed Sep 4, 2014
View reviewed changes

russnicoletti force-pushed the Bug-1055198 branch from 32d377c to 7910a5c Compare September 4, 2014 17:46

russnicoletti force-pushed the Bug-1055198 branch from 7910a5c to 12ab486 Compare September 10, 2014 20:35

russnicoletti force-pushed the Bug-1055198 branch from 12ab486 to 109638a Compare September 11, 2014 16:00

punamdahiya reviewed Sep 11, 2014
View reviewed changes

russnicoletti force-pushed the Bug-1055198 branch from 109638a to 262276a Compare September 17, 2014 23:52

russnicoletti force-pushed the Bug-1055198 branch from 262276a to b46a81b Compare September 18, 2014 05:05

russnicoletti force-pushed the Bug-1055198 branch from b46a81b to eba8538 Compare September 26, 2014 18:54

Bug 1055198 - [Video] Hide soft home key during full screen video pla…

6cdb5cf

…yback

russnicoletti force-pushed the Bug-1055198 branch from eba8538 to 6cdb5cf Compare October 1, 2014 20:20

mozilla-autolander-deprecated closed this Oct 1, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1055198 - [Video] Hide soft home key during full screen video playba... #23500

Bug 1055198 - [Video] Hide soft home key during full screen video playba... #23500

russnicoletti commented Aug 29, 2014

try-server-hook commented Aug 29, 2014

try-server-hook commented Aug 29, 2014

punamdahiya Sep 2, 2014

try-server-hook commented Sep 3, 2014

try-server-hook commented Sep 3, 2014

try-server-hook commented Sep 3, 2014

try-server-hook commented Sep 3, 2014

punamdahiya Sep 4, 2014

try-server-hook commented Sep 4, 2014

try-server-hook commented Sep 10, 2014

try-server-hook commented Sep 11, 2014

punamdahiya Sep 11, 2014

try-server-hook commented Sep 17, 2014

try-server-hook commented Sep 18, 2014

try-server-hook commented Sep 26, 2014

try-server-hook commented Oct 1, 2014

mozilla-autolander-deprecated commented Oct 1, 2014

Bug 1055198 - [Video] Hide soft home key during full screen video playba... #23500

Bug 1055198 - [Video] Hide soft home key during full screen video playba... #23500

Conversation

russnicoletti commented Aug 29, 2014

try-server-hook commented Aug 29, 2014

try-server-hook commented Aug 29, 2014

punamdahiya Sep 2, 2014

Choose a reason for hiding this comment

try-server-hook commented Sep 3, 2014

try-server-hook commented Sep 3, 2014

try-server-hook commented Sep 3, 2014

try-server-hook commented Sep 3, 2014

punamdahiya Sep 4, 2014

Choose a reason for hiding this comment

try-server-hook commented Sep 4, 2014

try-server-hook commented Sep 10, 2014

try-server-hook commented Sep 11, 2014

punamdahiya Sep 11, 2014

Choose a reason for hiding this comment

try-server-hook commented Sep 17, 2014

try-server-hook commented Sep 18, 2014

try-server-hook commented Sep 26, 2014

try-server-hook commented Oct 1, 2014

mozilla-autolander-deprecated commented Oct 1, 2014