-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Bug 1055198 - [Video] Hide soft home key during full screen video playba... #23500
Conversation
russnicoletti started tests. Results |
a0f3ee9
to
f44cbd0
Compare
russnicoletti started tests. Results |
} | ||
} | ||
|
||
|
||
form[role="dialog"][data-type="confirm"] menu button::-moz-focus-inner { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should move this check inside video.css as this will impact other apps such as gallery using confirm.css
f44cbd0
to
c0395d3
Compare
russnicoletti started tests. Results |
c0395d3
to
f76713b
Compare
russnicoletti started tests. Results |
f76713b
to
2eda3a6
Compare
russnicoletti started tests. Results |
2eda3a6
to
32d377c
Compare
russnicoletti started tests. Results |
@@ -192,7 +192,7 @@ <h1 id="overlay-title"></h1> | |||
<section> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add class="software-home-button" on menu at Line 187, that will be needed for the 'Add videos to get started' and related overlay shown
32d377c
to
7910a5c
Compare
russnicoletti started tests. Results |
7910a5c
to
12ab486
Compare
russnicoletti started tests. Results |
12ab486
to
109638a
Compare
russnicoletti started tests. Results |
@@ -9,6 +9,7 @@ const LAYOUT_MODE = { | |||
selection: 'layout-selection', | |||
fullscreenPlayer: 'layout-fullscreen-player' | |||
}; | |||
var foo = 0; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a redundant variable
109638a
to
262276a
Compare
russnicoletti started tests. Results |
262276a
to
b46a81b
Compare
russnicoletti started tests. Results |
b46a81b
to
eba8538
Compare
russnicoletti started tests. Results |
eba8538
to
6cdb5cf
Compare
russnicoletti started tests. Results |
This pull request has been closed due to tree stability issues. Please rebase and re-open the pull request if you still need to land this. Ensure the gaia-try run is green before landing. Sorry for any inconvenience. |
...ck