Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Bug 1062532 - minor refactor of Settings->About->Updates code (r=arthur) #23699

Merged
merged 1 commit into from Sep 4, 2014
Merged

Bug 1062532 - minor refactor of Settings->About->Updates code (r=arthur) #23699

merged 1 commit into from Sep 4, 2014

Conversation

autonome
Copy link
Contributor

@autonome autonome commented Sep 4, 2014

  • reorder code to be defined prior to being used
  • update some brackets per style guide
  • classList.add supports multiple args so convert to that

@try-server-hook
Copy link

autonome Dietrich Ayala (autonome) started tests. Results

@try-server-hook
Copy link

autonome Dietrich Ayala (autonome) started tests. Results

@try-server-hook
Copy link

autonome Dietrich Ayala (autonome) started tests. Results

@autonome autonome changed the title Bug 1062532 - minor refactor of Settings->About->Updates code (r=tbd) Bug 1062532 - minor refactor of Settings->About->Updates code (r=arthur) Sep 4, 2014
autonome added a commit that referenced this pull request Sep 4, 2014
@autonome
Merge pull request #23699 from autonome/1062532-updates-refactor
80abd6e 
Bug 1062532 - minor refactor of Settings->About->Updates code (r=arthur)
@autonome autonome merged commit 80abd6e into mozilla-b2g:master Sep 4, 2014
@autonome
Copy link
Contributor Author

autonome commented Sep 4, 2014

Only test failure was a calendar permafail, merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@autonome @try-server-hook