Bug 1058900 - [email] pinch/zoom mitigations #24137
Conversation
|
|
Andrew Sutherland (asutherland)
|
|
|
|
|
|
|
|
| baseScale = scale, | ||
| lastScale = scale, | ||
| var baseScale = Math.min(1, viewportWidth / scrollWidth), | ||
| // If there's an initial scale, use that, othrewise fall back to the base |
There was a problem hiding this comment.
nit: s/othrewise/otherwise/
asutherland
force-pushed
the
email-20-zoom-mitigate
branch
from
c2db5c0
to
5009357
Compare
| // b2g) where they can show up and cause themselves to exist in perpetuity. | ||
| var scrollPad = 16; | ||
| clickHandler, | ||
| putImagesBackIfNeeded) { |
There was a problem hiding this comment.
putImagesBackIfNeeded can be removed, it is not used anymore.
There was a problem hiding this comment.
putImagesBackIfNeeded removed (only took two review comments by you! ;)
|
I tried doing a reply-compose to a jetpack mailing list post, and noticed the blockquote line is now right against the edge. I added this to the DEFAULT_STYLE_TAG section: and that seemed to align it as before on master, and give a matching spacing on the right. The immediate child selector was necessary so as not to affect multiple nested blockquotes. |
|
hm, so blockquote-wise, I think the issue there is that in our compose UI we don't have the same "margin: 1rem 1.5rem" we have on .msg-body-container in message_reader. I propose that we instead just put a "margin: 0 1.5rem;" on ".cmp-body-html" since that's arguably the root problem. This is also consistent with the .cmp-body-text where we have "padding: 1rem 1.5rem 0px;" I'm going to do all these things now. |
…by cleaning up HTML display logic.
asutherland
force-pushed
the
email-20-zoom-mitigate
branch
from
5009357
to
a26ad1d
Compare
|
|
|
Ah right, that is better, more correct solution, the .cmp-body-html margin change. |
|
This pull request has been closed due to tree stability issues. Please rebase and re-open the pull request if you still need to land this. Ensure the gaia-try run is green before landing. Sorry for any inconvenience. |
No description provided.