Bug 1078174 - [Contact] Improve UI on contact settings #24885
Conversation
|
|
Pavel Ivanov (pivanov)
|
|
|
|
|
|
|
|
|
|
Pavel Ivanov (pivanov)
| @@ -574,6 +574,9 @@ contacts.Settings = (function() { | |||
| span.textContent = msgPart2; | |||
| fbTotalsMsg.appendChild(span); | |||
| } | |||
|
|
|||
| console.log(msgPart1); | |||
| console.log(msgPart2); | |||
There was a problem hiding this comment.
please remove this
|
|
| @@ -36,7 +36,7 @@ genericProgress = {{current}}/{{total}} | |||
| # Facebook import | |||
| facebook = Facebook | |||
| facebook-import-msg = {[ plural(imported) ]} | |||
| facebook-import-msg[zero] = No friends imported (out of {{total}}) | |||
| facebook-import-msg[zero] = 0/{{total}} friends imported | |||
| facebook-import-msg[one] = One friend imported (out of {{total}}) | |||
There was a problem hiding this comment.
you need to modify this string as well
|
|
| facebook-import-msg[zero] = No friends imported (out of {{total}}) | ||
| facebook-import-msg[one] = One friend imported (out of {{total}}) | ||
| facebook-import-msg[zero] = 0/{{total}} friends imported | ||
| facebook-import-msg[one] = 0/{{total}} friends imported |
There was a problem hiding this comment.
That string is incorrect. I think we can solve the entire problem by removing the plural form for this string i.e.
facebook-import-msg = {{imported/{{total}} friends imported
|
|
|
@jmcanterafonseca is it OK now? sorry for all iterations on this one |
| facebook-import-msg[one] = One friend imported (out of {{total}}) | ||
| facebook-import-msg = {{imported/{{total}} friends imported | ||
| facebook-import-msg[zero] = 0/{{total}} friends imported | ||
| facebook-import-msg[one] = 0/{{total}} friends imported |
There was a problem hiding this comment.
line 39 and 40 are no longer needed
|
|
|
|
|
|
|
|
|
|
|
|
Bug 1078174 - [Contact] Improve UI on contact settings
No description provided.