This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1068470 - [soft-home-button] SHB missing when lockscreen is on, and there is an incoming call #24893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Guillaume C. Marty (gmarty)
gmarty
force-pushed
the
Bug-1068470-soft-home-button-SHB-missing-when-lockscreen-is-on-and-there-is-an-incoming-call
branch
from
59a779d
to
8b5bdea
Compare
|
|
gmarty
force-pushed
the
Bug-1068470-soft-home-button-SHB-missing-when-lockscreen-is-on-and-there-is-an-incoming-call
branch
from
8b5bdea
to
b3dcfa0
Compare
|
|
gmarty
force-pushed
the
Bug-1068470-soft-home-button-SHB-missing-when-lockscreen-is-on-and-there-is-an-incoming-call
branch
from
b3dcfa0
to
4c36a68
Compare
|
|
gmarty
force-pushed
the
Bug-1068470-soft-home-button-SHB-missing-when-lockscreen-is-on-and-there-is-an-incoming-call
branch
from
4c36a68
to
0cdc4d0
Compare
|
|
| return winHeight === attentionWindowRect.height; | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
can you add a test where we unlock and check that the height takes the shb into account?
…nd there is an incoming call
gmarty
force-pushed
the
Bug-1068470-soft-home-button-SHB-missing-when-lockscreen-is-on-and-there-is-an-incoming-call
branch
from
0cdc4d0
to
b02ecab
Compare
|
|
mikehenrty
added a commit
that referenced
this pull request
Oct 9, 2014
…B-missing-when-lockscreen-is-on-and-there-is-an-incoming-call Bug 1068470 - [soft-home-button] SHB missing when lockscreen is on, and there is an incoming call
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.