Bug 1042939 - Resurrect periodic sync, alarms refactor r=millermedeiros #25282
Conversation
lambdabaa
force-pushed
the
alarms-refactor
branch
3 times, most recently
from
5bb6a3b
to
af8724c
Compare
|
|
Gareth Aye (gaye)
lambdabaa
changed the title
| this.errorController = new ErrorController(this); | ||
| notificationsController.app = this; | ||
| this.notificationsController = notificationsController; |
There was a problem hiding this comment.
since it's static I would not attach it to the app module.. we can simply require('controllers/notifications') when needed!
There was a problem hiding this comment.
Sounds good to me!
lambdabaa
force-pushed
the
alarms-refactor
branch
from
af8724c
to
9285de2
Compare
| // Find the event and busytime associated with this alarm. | ||
| return Promise.all([ | ||
| findObjectById(alarm.eventId, eventStore, trans), | ||
| findObjectById(alarm.busytimeId, busytimeStore, trans) |
There was a problem hiding this comment.
shouldn't we update the eventStore.get and busytimeStore.get to return a promise instead of creating an intermediary helper method?
There was a problem hiding this comment.
I think they do return promises... I think I thought findObjectById would help clean things up for other reasons
There was a problem hiding this comment.
Maybe findObjectById is just unnecessary lol
|
|
lambdabaa
force-pushed
the
alarms-refactor
branch
from
4f07dc1
to
b3eaf3e
Compare
|
|
||
| navigator.mozApps.getSelf().onsuccess = (event) => { | ||
| var app = event.target.result; | ||
| var url = message.imageURL.split('?')[1]; |
There was a problem hiding this comment.
are you sure we don't need to encode/decode the URL?
|
|
lambdabaa
force-pushed
the
alarms-refactor
branch
from
21093c1
to
9217f67
Compare
|
|
Bug 1042939 - Resurrect periodic sync, alarms refactor r=millermedeiros
No description provided.