This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1083820 - [Calendar] update MonthsDay view to use DayObserver r=gaye #25413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millermedeiros
changed the title
|
|
Miller Medeiros (millermedeiros)| }); | ||
| }, | ||
| records.sort((a, b) => { | ||
| return a.busytime.startDate - b.busytime.startDate; |
There was a problem hiding this comment.
just realized that we should always put "all day" events at the top, even if we have other events that starts at midnight. will update this logic.
in fact I even think that we should probably update the day observer logic so the records are already split into "events" and "all day" events. it will avoid duplication and simplify things.
|
|
| // without need (causes error on unit tests) | ||
| debouncedEmit[dayId].cancel(); | ||
| delete debouncedEmit[dayId]; | ||
| } | ||
| delete cachedRecords[dayId]; |
There was a problem hiding this comment.
We wouldn't need to delete it if !debouncedEmit[dayId] ?
millermedeiros
force-pushed
the
1083820-months-day-refactor
branch
from
530e974
to
8663786
Compare
|
|
millermedeiros
added a commit
that referenced
this pull request
Oct 29, 2014
…ctor Bug 1083820 - [Calendar] update MonthsDay view to use DayObserver r=gaye
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
294 additions and 2,208 deletions!!!