Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Bug 1089511 - refactor system/js/bluetooth to future compatible format #25791

Merged
merged 1 commit into from Nov 21, 2014
Merged

Bug 1089511 - refactor system/js/bluetooth to future compatible format #25791

merged 1 commit into from Nov 21, 2014

Conversation

gasolin
Copy link
Contributor

@gasolin gasolin commented Nov 4, 2014

No description provided.

@try-server-hook
Copy link

gasolin gasolin (gasolin) started tests. Results

alivedise
alivedise reviewed Nov 4, 2014
View reviewed changes
apps/system/js/power_save.js
// Turn off Geolocation
'geolocation.enabled': false
};

this.setMozSettings(settingsToSet);
// Turn off Bluetooth
Bluetooth.disable();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a good idea to couple bluetooth.
Please consider to dispatch event or implement System.request('BluetoothCore.toggle');

@try-server-hook
Copy link

gasolin gasolin (gasolin) started tests. Results

@try-server-hook
Copy link

gasolin gasolin (gasolin) started tests. Results

alivedise
alivedise reviewed Nov 5, 2014
View reviewed changes
apps/system/js/power_save.js
// Turn off Geolocation
'geolocation.enabled': false
};

this.setMozSettings(settingsToSet);
// Turn off Bluetooth
window.dispatchEvent(new CustomEvent('bluetooth-disable'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

event name: request-disable-bluetooth

@try-server-hook
Copy link

gasolin gasolin (gasolin) started tests. Results

@try-server-hook
Copy link

gasolin gasolin (gasolin) started tests. Results

@try-server-hook
Copy link

gasolin gasolin (gasolin) started tests. Results

@try-server-hook
Copy link

gasolin gasolin (gasolin) started tests. Results

@try-server-hook
Copy link

gasolin gasolin (gasolin) started tests. Results

alivedise
alivedise reviewed Nov 12, 2014
View reviewed changes
apps/system/js/bluetooth.js
// and try to get defaultAdapter at this moment
// when bluetooth adapter is ready, a.k.a enabled,
// emit event to notify QuickSettings and try to get
// defaultAdapter at this moment
bluetooth.onadapteradded = function bt_onAdapterAdded() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try this out
bluetooth.addEventListener('adapteradded', this);

@try-server-hook
Copy link

gasolin gasolin (gasolin) started tests. Results

@try-server-hook
Copy link

gasolin gasolin (gasolin) started tests. Results

@try-server-hook
Copy link

gasolin gasolin (gasolin) started tests. Results

@try-server-hook
Copy link

gasolin gasolin (gasolin) started tests. Results

@try-server-hook
Copy link

gasolin gasolin (gasolin) started tests. Results

@try-server-hook
Copy link

gasolin gasolin (gasolin) started tests. Results

gasolin added a commit that referenced this pull request Nov 21, 2014
@gasolin
Merge pull request #25791 from gasolin/issue-1089511-3
60d2ad4 
Bug 1089511 - refactor system/js/bluetooth to future compatible format, r=alive&Ian
@gasolin gasolin merged commit 60d2ad4 into mozilla-b2g:master Nov 21, 2014
gasolin added a commit to gasolin/gaia that referenced this pull request Nov 24, 2014
@gasolin
Revert "Merge pull request mozilla-b2g#25791 from gasolin/issue-10895…
4ceae6c 
…11-3"

This reverts commit 60d2ad4, reversing
changes made to 929a3e9.
gasolin added a commit that referenced this pull request Nov 24, 2014
@gasolin
Merge pull request #26408 from gasolin/master
4c32c19 
Revert "Merge pull request #25791 from gasolin/issue-1089511-3"
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@gasolin @try-server-hook @alivedise