Bug 1097035 - Write a test to verify that the user can forward a sent me... #26221
Conversation
|
|
viorelaioia
| _text_message_content = "Automated Test %s" % str(time.time()) | ||
|
|
||
| # Send a SMS to the device | ||
| self.data_layer.send_sms(self.testvars['local_phone_numbers'][0], _text_message_content) |
There was a problem hiding this comment.
I would move this sent to the setUp(self) function because having an SMS on the device is a prerequisite.
def setUp(self):
GaiaTestCase.setUp(self)
self._text_message_content = "Automated Test %s" % str(time.time())
# Send a SMS to the device
self.data_layer.send_sms(self.testvars['local_phone_numbers'][0], self._text_message_content)There was a problem hiding this comment.
Just wondering, shoud we send this SMS to the device under test? We only need to have a sent message in the inbox.
viorelaioia-zz
force-pushed
the
bug_1097035
branch
2 times, most recently
from
250b033
to
30f767a
Compare
|
|
|
started an adhoc here: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/341/console |
viorelaioia-zz
force-pushed
the
bug_1097035
branch
from
30f767a
to
9c46966
Compare
|
|
| # Launch the app | ||
| messages = Messages(self.marionette) | ||
| messages.launch() | ||
| message_thread = messages.tap_first_received_message() |
There was a problem hiding this comment.
I will open a new bug to rename tap_first_received_message() method, as we are tapping the first message displayed, which can be both received or sent message.
viorelaioia-zz
force-pushed
the
bug_1097035
branch
from
9c46966
to
d8da850
Compare
|
|
| self.assertEqual(new_message.recipients[0].text, u'') | ||
|
|
||
| # Check that the message field has the content we expect | ||
| self.assertEqual(message_thread.sent_messages[1].text, self._text_message_content) |
There was a problem hiding this comment.
You should assert against the new_message not the old message thread.
There was a problem hiding this comment.
ooops, I know how I missed that. Updated now :)
viorelaioia-zz
force-pushed
the
bug_1097035
branch
from
d8da850
to
7f2abe1
Compare
|
|
|
lgtm |
Bug 1097035 - Write a test to verify that the user can forward a sent me...
...ssage