This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Fixes bug 1005331 jshint fixes for shared/js/media r=djf #27089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sudheesh Singanamalla (sudheesh001)
| @@ -94,6 +95,7 @@ function parseJPEGMetadata(file, metadataCallback, metadataError) { | |||
|
|
|||
| case 0xE1: // APP1 segment. Probably holds EXIF metadata | |||
| parseAPP1(data); | |||
| break; | |||
There was a problem hiding this comment.
You can't add a break here. The comment that follows this line indicates that this is an intentional fallthough to the default case. I suppose you might have to add a comment that turns of jshint warnings on this line. I'm not sure what that comment is.
sudheesh001
force-pushed
the
Patch_1005331
branch
from
6f2ebba
to
38b1738
Compare
|
|
sudheesh001
force-pushed
the
Patch_1005331
branch
from
38b1738
to
b114064
Compare
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.