Bug 1109422 - [AUM] Updates to support monthly active users #27286
Conversation
|
|
Marshall Culpepper (marshall)
| this.transmit(); | ||
| } | ||
| } | ||
| // Otherwise, if we have not failed to transmit, then send it if the | ||
| // reporting interval has elapsed. | ||
| else if (absoluteTime - this.metrics.startTime() > AUM.REPORT_INTERVAL) { | ||
| else if (totalElapsed > AUM.REPORT_INTERVAL) { |
There was a problem hiding this comment.
This will only send the report after two weeks of the user having the phone turned on. If a user turns off their phone every night and only has it on for 12 hours a day, then their reports will only be sent every 4 weeks.
I think you are going to have to use absolute time for at least some of this module.
marshall
force-pushed
the
bug1109422_mauChanges
branch
from
a3260f3
to
d31bf06
Compare
|
|
| data.deviceinfo = deviceinfo; | ||
| AUM.getSettings(deviceInfoQuery, function(deviceInfo) { | ||
| data.deviceinfo = deviceInfo; | ||
| data.simInfo = getSIMInfo(); |
There was a problem hiding this comment.
Your data object here has one property with lowercase info and one with capitalized Info. Did you mean to type data.deviceInfo here?
marshall
force-pushed
the
bug1109422_mauChanges
branch
from
d31bf06
to
0072226
Compare
|
Autolander could not find a bug number in your pull request title. All pull requests should be in the format of: Bug [number] - [description]. |
|
|
| var setting = sharePerformance.name; | ||
| var settings = navigator.mozSettings; | ||
| var req = settings && settings.createLock().get(setting); | ||
| if (req) { |
There was a problem hiding this comment.
not really needed imo, if req is null we won't get into onsuccess anyway.
marshall
force-pushed
the
bug1109422_mauChanges
branch
from
0072226
to
6e7cdf5
Compare
|
Autolander could not find a bug number in your pull request title. All pull requests should be in the format of: Bug [number] - [description]. |
|
|
marshall
changed the title
marshall
force-pushed
the
bug1109422_mauChanges
branch
from
6e7cdf5
to
dafac95
Compare
|
|
marshall
force-pushed
the
bug1109422_mauChanges
branch
from
dafac95
to
c5b82fa
Compare
|
|
Bug 1109422 - [AUM] Updates to support monthly active users
Bug 1109422 - [AUM] Updates to support monthly active users
Updates made to support monthly active users calculation for the Metrics team:
https://bugzilla.mozilla.org/show_bug.cgi?id=1109422