Bug 1123164 - [Settings]There is no SIM settings icons when you insert SIM2 only in Settings -> Cellular & Data. #27515

mpizza · 2015-01-20T07:08:54Z

No description provided.

try-server-hook · 2015-01-20T07:09:38Z

mpizza GaryChen, PYChen, Gary (mpizza) started tests. Results

crh0716 · 2015-01-20T10:41:43Z

apps/settings/js/main.js

+            break;
+          default:
+            if (pendingTargetPanel) {
+              SettingsService.navigate(pendingTargetPanel);
            }


nit: Let's still add a break here.

try-server-hook · 2015-01-21T08:37:16Z

mpizza GaryChen, PYChen (mpizza) started tests. Results

try-server-hook · 2015-01-21T09:16:14Z

mpizza GaryChen, PYChen (mpizza) started tests. Results

try-server-hook · 2015-01-22T04:36:14Z

mpizza GaryChen, PYChen (mpizza) started tests. Results

crh0716 · 2015-01-23T08:08:25Z

apps/settings/js/main.js

@@ -5,6 +5,7 @@ require(['config/require'], function() {
    // The following are the scripts used by many other scripts. We load them
    // at once here. These should be move to the dependency of each panel in the
    // future.
+    var DsdsSettings = require('dsds_settings');


nit: Please move this to the line under var Settings = require('settings');.

try-server-hook · 2015-01-23T09:07:05Z

mpizza GaryChen, PYChen (mpizza) started tests. Results

try-server-hook · 2015-01-24T12:23:00Z

mpizza GaryChen, PYChen (mpizza) started tests. Results

try-server-hook · 2015-01-24T15:15:38Z

mpizza GaryChen, PYChen (mpizza) started tests. Results

try-server-hook · 2015-01-26T00:55:07Z

mpizza GaryChen, PYChen (mpizza) started tests. Results

try-server-hook · 2015-01-26T02:23:31Z

mpizza GaryChen, PYChen (mpizza) started tests. Results

try-server-hook · 2015-01-27T02:20:24Z

mpizza GaryChen, PYChen (mpizza) started tests. Results

try-server-hook · 2015-01-27T07:57:24Z

mpizza GaryChen, PYChen (mpizza) started tests. Results

…t SIM2 only in Settings -> Cellular & Data. r=arthurcc.

try-server-hook · 2015-01-28T17:19:09Z

mpizza GaryChen, PYChen (mpizza) started tests. Results

Bug 1123164 - [Settings]There is no SIM settings icons when you insert SIM2 only in Settings -> Cellular & Data. r=arthurcc.

crh0716 reviewed Jan 20, 2015
View reviewed changes

mpizza force-pushed the bug_1123164_dsds_issue branch 4 times, most recently from d135ea8 to 53f22fc Compare January 21, 2015 08:36

mpizza force-pushed the bug_1123164_dsds_issue branch from 53f22fc to 0030169 Compare January 21, 2015 09:15

mpizza force-pushed the bug_1123164_dsds_issue branch from 0030169 to 602ba1e Compare January 22, 2015 04:35

crh0716 reviewed Jan 23, 2015
View reviewed changes

mpizza force-pushed the bug_1123164_dsds_issue branch from 602ba1e to 8fa279a Compare January 23, 2015 09:06

mpizza force-pushed the bug_1123164_dsds_issue branch from 8fa279a to 860e55c Compare January 24, 2015 12:22

mpizza force-pushed the bug_1123164_dsds_issue branch from 860e55c to 53ef63d Compare January 24, 2015 15:14

mpizza force-pushed the bug_1123164_dsds_issue branch from 53ef63d to 1b2c971 Compare January 26, 2015 00:54

mpizza force-pushed the bug_1123164_dsds_issue branch from 1b2c971 to 6b3f154 Compare January 26, 2015 02:22

mpizza force-pushed the bug_1123164_dsds_issue branch from 6b3f154 to 1c670a4 Compare January 27, 2015 02:19

mpizza force-pushed the bug_1123164_dsds_issue branch from 1c670a4 to 6f088b5 Compare January 27, 2015 07:56

Bug 1123164 - [Settings]There is no SIM settings icons when you inser…

ba73b28

…t SIM2 only in Settings -> Cellular & Data. r=arthurcc.

mpizza force-pushed the bug_1123164_dsds_issue branch from 6f088b5 to ba73b28 Compare January 28, 2015 17:18

mpizza added a commit that referenced this pull request Jan 29, 2015

Merge pull request #27515 from mpizza/bug_1123164_dsds_issue

5a6e46a

Bug 1123164 - [Settings]There is no SIM settings icons when you insert SIM2 only in Settings -> Cellular & Data. r=arthurcc.

mpizza merged commit 5a6e46a into mozilla-b2g:master Jan 29, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1123164 - [Settings]There is no SIM settings icons when you insert SIM2 only in Settings -> Cellular & Data. #27515

Bug 1123164 - [Settings]There is no SIM settings icons when you insert SIM2 only in Settings -> Cellular & Data. #27515

mpizza commented Jan 20, 2015

try-server-hook commented Jan 20, 2015

crh0716 Jan 20, 2015

try-server-hook commented Jan 21, 2015

try-server-hook commented Jan 21, 2015

try-server-hook commented Jan 22, 2015

crh0716 Jan 23, 2015

try-server-hook commented Jan 23, 2015

try-server-hook commented Jan 24, 2015

try-server-hook commented Jan 24, 2015

try-server-hook commented Jan 26, 2015

try-server-hook commented Jan 26, 2015

try-server-hook commented Jan 27, 2015

try-server-hook commented Jan 27, 2015

try-server-hook commented Jan 28, 2015

Bug 1123164 - [Settings]There is no SIM settings icons when you insert SIM2 only in Settings -> Cellular & Data. #27515

Bug 1123164 - [Settings]There is no SIM settings icons when you insert SIM2 only in Settings -> Cellular & Data. #27515

Conversation

mpizza commented Jan 20, 2015

try-server-hook commented Jan 20, 2015

crh0716 Jan 20, 2015

Choose a reason for hiding this comment

try-server-hook commented Jan 21, 2015

try-server-hook commented Jan 21, 2015

try-server-hook commented Jan 22, 2015

crh0716 Jan 23, 2015

Choose a reason for hiding this comment

try-server-hook commented Jan 23, 2015

try-server-hook commented Jan 24, 2015

try-server-hook commented Jan 24, 2015

try-server-hook commented Jan 26, 2015

try-server-hook commented Jan 26, 2015

try-server-hook commented Jan 27, 2015

try-server-hook commented Jan 27, 2015

try-server-hook commented Jan 28, 2015