This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1130547 - [email] marionettejs tests that use notification iconURL fail #28276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
James Burke (jrburke)
mozilla-autolander-deprecated
added a commit
that referenced
this pull request
Feb 18, 2015
…-test-notification to mozilla-b2g:master
mozilla-autolander-deprecated
added a commit
that referenced
this pull request
Feb 18, 2015
…-test-notification to mozilla-b2g:master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apps/email/test/marionette/lib/notification.js has the core of the change, to use Notification.get() to get the notifications.
There were some other changes for allowing the files to be linted by jshint, and then the tests themselves to use the new methods in lib/notification.js. With this, all the marionette email tests pass locally for me.
email_evt.js was no longer needed because lib/notification.js can do the event emitting internally, and it makes more sense to do so internally to keep the knowledge of notification structures to that file.