This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1142572 - Use ManifestHelper's displayName instead of short_name #29023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfoster
force-pushed
the
manifest-displayname-bug-1142572
branch
2 times, most recently
from
68447da
to
970a600
Compare
|
http://docs.taskcluster.net/tools/task-graph-inspector/#pFs2EBqvSQKlJd8Wzlqrcw The pull request failed to pass integration tests. It could not be landed, please try again. |
sfoster
force-pushed
the
manifest-displayname-bug-1142572
branch
from
970a600
to
dedd57b
Compare
mozilla-autolander-deprecated
added a commit
that referenced
this pull request
Mar 25, 2015
…name-bug-1142572 to mozilla-b2g:master
mozilla-autolander-deprecated
added a commit
that referenced
this pull request
Mar 26, 2015
…name-bug-1142572 to mozilla-b2g:master
|
http://docs.taskcluster.net/tools/task-graph-inspector/#mi6GtyXST3eJb0S2gyNw-w The pull request failed to pass integration tests. It could not be landed, please try again. |
rvandermeulen
added a commit
that referenced
this pull request
Mar 26, 2015
Bug 1142572 - Use ManifestHelper's displayName instead of short_name
| manifestPromise.then((function(manifestData) { | ||
| if (manifestData) { | ||
| this.installAppButtonListener = this._installApp.bind(this); | ||
| this.installAppButton.addEventListener('click', | ||
| this.installAppButtonListener); | ||
| this.appNameText.textContent = manifestData.short_name || | ||
| manifestData.name; | ||
| this.appNameText.textContent = manifestData.displayName; |
There was a problem hiding this comment.
This won't work, manifestData comes from WebManifestHelper which is a different thing to ManifestHelper, it fetches and parses W3C web app manifests for apps which are not installed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1142572
Going through and replacing the name || short_name assignments with displayName, where the ManifestHelper is used. Also got rid of the AppWindow.prototype.shortName and its use in task manager (Card) - we always display short_name when it is defined, so we don't need this distinction and we can just set .name from the displayName of the ManifestHelper and use that.