This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1170067 - [Stingray][EPG] Make program element as a web component #30339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sean2449
commented
Jun 1, 2015
sean2449
commented
- Make program element as a web component in epg_program
- Move out related css
- Add test cases
| this.progressElement.style.transform = 'scaleX(1)'; | ||
| }; | ||
|
|
||
| proto.setStartTime = function(time) { |
There was a problem hiding this comment.
How about to use property getter and setter for these parts?
startTime, title, titlePadding (maybe), duration
* Make program element as a web component in epg_program * Move out related css * Add test cases
sean2449
force-pushed
the
Bug-1170067-move-program
branch
from
13a0bde
to
d74a7a2
Compare
sean2449
added a commit
that referenced
this pull request
Jun 2, 2015
Bug 1170067 - [Stingray][EPG] Make program element as a web component, r=johnhu
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.