This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1169137 - [Stingray] setInterval clock implementation sometimes s… #30789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| refresh(new Date()); | ||
| refresh(now); | ||
|
|
||
| self.timeoutId = setTimeout(loop, 1000 - now.getMilliseconds()); |
There was a problem hiding this comment.
how about this.timeoutId = setTimeout(this._start.bind(this), 1000 - now.getMilliseconds());
We don't need to nest a function here then.
…kips a couple seconds * Change setInterval to time adjusted setTimeout.
begeeben
force-pushed
the
1169137_setinterval_clock
branch
from
d408716
to
e06bcc4
Compare
begeeben
added a commit
that referenced
this pull request
Jul 3, 2015
Bug 1169137 - [Stingray] setInterval clock implementation sometimes sometimes skips a couple seconds, r=rexboy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…kips a couple seconds