This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1174892 - Gaiatest needs to be updated for treeherder client changes #30822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.logger.debug('Sending results to Treeherder: %s' % | ||
| job_collection.to_json()) | ||
| response = request.post(job_collection) | ||
| response = client.post_collection(project, |
There was a problem hiding this comment.
post_collection doesn't provide a return value anymore, I'd probably just suggest just calling it and letting it throw an exception if there's an error. Other than that, this looks fine. You'll also want to bump the required version of treeherder-client, of course.
mwargers
added a commit
that referenced
this pull request
Jul 6, 2015
Bug 1174892 - Gaiatest needs to be updated for treeherder client changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.