Bug 1183727 - [Contacts][NGA] Create #update view and connect it to #… #31372
Conversation
borjasalguero
force-pushed
the
update_selfcontained_rebased
branch
from
0d6a195
to
767ac3c
Compare
| MainNavigation.go('view-contact-details', 'go-deeper'); | ||
| } | ||
| }); | ||
| window.location.href = ParamUtils.generateUrl('detail', {contact:id}); |
There was a problem hiding this comment.
I'm wondering if this line of code should be executed ever. If we are not handling any activity we should have gone through L243 right?
We could potentially also save some cycles checking that the activity is import or pick before calling the ContactsService
There was a problem hiding this comment.
This has been refactored within the list patch, that's why I'm just keeping the old code (contacts.js will dissapear soon! :) )
|
The delete operation form the contact form should ask you for confirmation. |
borjasalguero
force-pushed
the
update_selfcontained_rebased
branch
2 times, most recently
from
85dc1cb
to
ddbaa1c
Compare
|
I'm experiencing a race condition when removing a contact: E/Communications(11617): [JavaScript Error: "ReferenceError: navigationStack is not defined" {file: "app://communications.gaiamobile.org/contacts/js/main_navigation.js" line: 6}] |
borjasalguero
force-pushed
the
update_selfcontained_rebased
branch
from
ddbaa1c
to
deba62d
Compare
|
Updated shielded to the race condition |
borjasalguero
force-pushed
the
update_selfcontained_rebased
branch
2 times, most recently
from
c9997d7
to
9a50c35
Compare
…open within Contacts App r=arcturus
borjasalguero
force-pushed
the
update_selfcontained_rebased
branch
from
9a50c35
to
a191600
Compare
…ased Bug 1183727 - [Contacts][NGA] Create #update view and connect it to #…
…open within Contacts App r=arcturus