Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Initial Gecko update prompt based on ModalDialog #3447

Closed
wants to merge 1 commit into from

Conversation

marshall
Copy link
Contributor

This corresponds w/ platform work in gecko Bug 740720:
https://bugzilla.mozilla.org/show_bug.cgi?id=740720

We are also waiting further UX clarification as pointed out by Josh here:
https://wiki.mozilla.org/Gaia/System/Updates

@vingtetun
Copy link
Contributor

I'm a bit worried about adding a new prompt dialog. @timdream / @alivedise Is there some dialog code that can be reused?

@alivedise
Copy link
Contributor

(I didn't read the full story about this yet...read later)

  1. Quick answer: NO
  2. But we should do that because currently we have at least 3 dialogs:
    ModalDialog, PermissionDialog, TrustedDialog(?)... and there're some important features they must have:
  • Block background-app prompt
  • Handle app switch
  • Resize when keyboard pops

@timdream
Copy link
Contributor

I propose we have Settings app handling this and emit a mozNotification to the system. In this way, the update dialog can be just a panel from Settings app, which is a lot easier. @lco would need to update the spec for this though.

@marshall
Copy link
Contributor Author

@vingtetun @alivedise FWIW, this does try to reuse as much code in ModalDialog as possible.

@timdream Wouldn't a mozNotification be non-blocking? Updates will need to be handled with a slightly higher priority. According to the current bugs filed / implementation, updates will only be optional in certain cases like a roaming connection, no connectivity, or when the user postpones for a short-ish period of time

@timdream
Copy link
Contributor

@timdream Wouldn't a mozNotification be non-blocking? Updates will need to be handled with a slightly higher priority. According to the current bugs filed / implementation, updates will only be optional in certain cases like a roaming connection, no connectivity, or when the user postpones for a short-ish period of time

I am not familiar with the spec. If the spec requirement said so, then so be it. Such Windows Update-like update prompt is far from ideal, though.

@marshall
Copy link
Contributor Author

I am not familiar with the spec. If the spec requirement said so, then so be it. Such Windows Update-like update prompt is far from ideal, though.

It looks like the spec is far from settled :) @jcarpenter just posted his Gecko update UX Draft here:
https://wiki.mozilla.org/Gaia/System/Updates#Draft_process_for_atomic_Gecko.2BGaia_updates

There are several different prompts in this UX flow, and it sounds like the current approach will need to be rethought. We are meeting today to flesh this all out, so I will come back with an update. It may be that this pull request gets closed in favor of something more robust.

@jcarpenter
Copy link
Contributor

One thing to keep in mind: that's just an early draft to help drive the conversation. I'm very eager to work with the devs here to explore our options. We don't need to invent the perfect flow in v1 :)

@etiennesegonzac
Copy link
Contributor

Closing here, something awesome coming :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
6 participants