Make the unlock SIM dialog work after changing -bug774114- a bit the pla... #3507
Conversation
…platform API (mainly return values).
|
@evelynhung You are working on Settings app version of this right? |
|
@jaoo hi, I'm working on this, and noticed API changes. Please update API spec, I really rely on it. (nice documentation!) Thank you so much. |
| } | ||
| pinLock.hideKeypad(); | ||
| }; | ||
| unlock.onerror = function() { |
There was a problem hiding this comment.
I tested but the onerror callback is not fired when input wrong pin, could you check this?
There was a problem hiding this comment.
The 'onerror' function is called but you cannot access 'retryCount' member since the error event is not fired properly. Also we are redefining error report police so I'll you update about the changes and decisions. Patch is comming. See https://bugzilla.mozilla.org/show_bug.cgi?id=783525.
There was a problem hiding this comment.
Thanks, I will follow the updates of this patch.
|
/botio lint |
From: Bot.io (Main)ReceivedCommand cmd_lint from @timdream received. Current queue size: 0 Live output at: http://50.116.11.35:8000/e69e7a55c90e21c/output.txt |
From: Bot.io (Main)FailedFull output at http://50.116.11.35:8000/e69e7a55c90e21c/output.txt Total script time: 5.04 mins Lint: FAILED |
|
I am going to merge this. This can be removed later when @evelynhung finishes SIM lock in Settings app. CCing @fabi1cazenave |
Make the unlock SIM dialog work after changing -bug774114- a bit the pla...
|
OK, thanks. |
...tform API (mainly return values).
After landing bug 774114 some changes are needed to make the unlock SIM dialog work. I have only changed a bit the logic underneath and it needs more work. Anyone willing to continue with that work? Style and visuals are really old. I'll update the information provided in the API specification asap for reflecting latest changes.