Screen brightness changes due to device light sensor should be graceful

[timdream]

and,

• Real fix of #2166: Shorter screen off time if lock screen is never unlocked (correction error made in Make the screen turn off earlier if it was never unlocked, fix #2166 #3858)
• Revert workaround for #3268 since https://bugzilla.mozilla.org/show_bug.cgi?id=781076 is fixed

[etiennesegonzac]

Beautiful.

I'd like to rename the dim function since it's not always making the screen darker but sometimes brighter.
But it can be done in a follow up.

[timdream]

I'd like to rename the dim function since it's not always making the screen darker but sometimes brighter. But it can be done in a follow up.

Can you suggest a verb for this? I am running out of English vocab, thanks.

[nhirata]

Brightness ? Like TV brightness... http://www.synonyms.net/synonym/light

[timdream]

@nhirata There is already a function named setScreenBrightness() which starts the dim() loop. I honestly don't want to name it setScreenBrightnessForReal() Orz

[nhirata]

lol. point taken.

[etiennesegonzac]

transitionBrightness() ? changeBrightness() ?

The issue is everything feels heavy compared to a 3 letter function :)

[timdream]

transitionBrightness() sounds good.