Bug 802095 - [Media Storage] TypeError: dsfile.lastModifiedDate is null #5839
Conversation
| @@ -988,7 +988,8 @@ var MediaDB = (function() { | |||
| // 4a: date and size are the same for both: do nothing | |||
| // 4b: file has changed: it is both a deletion and a creation | |||
| if (dsfile.name === dbfile.name) { | |||
| if (dsfile.lastModifiedDate.getTime() !== dbfile.date || | |||
| if (dsfile.lastModifiedDate && | |||
There was a problem hiding this comment.
I can't review this without more explanation...
the lastModifiedDate = null is a known device storage bug, and a fix is pending, I think.
If we make the change you propose here, where will we handle these files with no date? Are you suggesting that if a no-date file has the same name and size as a known existing file we treat it as an existing file rather than a new file?
Don't you need parens around teh || expression, though? I think your code doesn't test size if the date is null
There was a problem hiding this comment.
On further thought, I understand this and like it. And I was wrong about the parens. I'd like (but you don't need) parens around the && expression.
Have you checked that there aren't any other similar lastModifiedDate uses in the code?
Thanks for fixing this. r+
There was a problem hiding this comment.
I'd like (but you don't need) parens around the && expression.
I agree, it's much more explicit - will do.
Have you checked that there aren't any other similar lastModifiedDate uses in the code?
No... let me check that right away. Should I file new bugs for these?
There was a problem hiding this comment.
If there are any, I'd just fix them in this patch. Note that null is probably okay, as long as we don't try to call getTime() on it.
There was a problem hiding this comment.
Didn't find any other usages except one that was already worked around and waits for bug 793955.
|
Thanks for the update. r+ to land this. |
…ll r=djf a=vingtetun
…lastModifiedDate Bug 802095 - [Media Storage] TypeError: dsfile.lastModifiedDate is null r=djf a=vingtetun
No description provided.