Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Bug 805532 - [gallery] share activity does not expose the filename of the shared file #6012

Merged
merged 1 commit into from Oct 26, 2012

Conversation

asutherland
Copy link
Contributor

r? @davidflanagan for a fix to https://bugzilla.mozilla.org/show_bug.cgi?id=805532

Expose the filenames (sans path components) of shared images. This includes a change to the share-receiver to show the filenames.

For posterity: This patch is being made for the blocking-basecamp e-mail bug https://bugzilla.mozilla.org/show_bug.cgi?id=799827 about e-mail sharing images.

@davidflanagan
Copy link

r+, but note that the patch supporting blobs has just landed, so soon we'll convert the share activity to use blobs instead of urls. As you noted, however, the filenames will still probably be necessary.

@davidflanagan
Copy link

Note also that attaching a dummy file in bugzilla and requesting review there is more likely to get my attention. With the new bugzilla transition, I'm not tracking my github mail as carefully.

@asutherland
Copy link
Contributor Author

Yes, I've been tracking the blob work. I am very psyched about that. (If only it had been a few days earlier; converting the base64 back to a blob without utf-8 conversion betrayal without a 'binary' encoding was probably the hardest part of hooking up the front-end of the share activity.)

Thanks for the review, and I'll be sure to route things through the bugzilla flag mechanisms.

… the shared file. r=djf, a=blocking-basecamp for Bug 799827

Expose the filenames (sans path components) of shared images.
asutherland added a commit that referenced this pull request Oct 26, 2012
Bug 805532 - [gallery] share activity does not expose the filename of the shared file, r=djf, a=blocking-basecamp for Bug 799827
@asutherland asutherland merged commit 78451cc into mozilla-b2g:master Oct 26, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants