Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Bug 806386 - [BB][CostControl] Apply building blocks [buttons] #6058

Merged

Conversation

basiclines
Copy link
Contributor

Removed un-used bb files and linked to shared/buttons.css

BZ: https://bugzilla.mozilla.org/show_bug.cgi?id=806386

Please @lodr @arcturus take a look!

@basiclines
Copy link
Contributor Author

@fabi1cazenave I've removed the li label definition in shared/style/buttons.css as it is too much generic and could affect system and app styles, and visually speaking is only applied in Contacts, (Contacts already have styles for that)

@@ -92,14 +92,6 @@ a[role="button"][aria-disabled="true"].danger {
* Buttons inside lists
* ---------------------------------- */

li label {
font: 1.6rem/1em "MozTT", Sans-serif;
text-transform: uppercase;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m soooooo glad this rule went away with the flush. ;-)

@fabi1cazenave
Copy link
Contributor

@basiclines the shared/style/buttons.css part is OK for me, I agree the building block is better without this rule. Can I count on you to address the possible follow-ups? (e.g. if some app suffers from the removal of this rule, will you submit a patch?)

@basiclines
Copy link
Contributor Author

Sure, but i think that right now the only possible app that could use that is Contacts, and that has his own styles for that label. Anyway if something breaks, i will submit a patch!

@fabi1cazenave
Copy link
Contributor

thanks :)

</button>
</li>
<li>
<button class="icon icon-topupcode" id="balance-tab-topup-button" data-l10n-id="topup-button">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, indent this element properly.

@basiclines
Copy link
Contributor Author

@lodr Nits fixed!

@delapuente
Copy link
Contributor

Let me check the functionality and I'll give you the r+

@delapuente
Copy link
Contributor

Ok, I did not notice any inconsistency.

basiclines pushed a commit that referenced this pull request Oct 30, 2012
…locks

Bug 806386 - [BB][CostControl] Apply building blocks [buttons]
@basiclines basiclines merged commit ace1425 into mozilla-b2g:master Oct 30, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants