This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 807418 - trigger change event for each click on the select option #6581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,6 +53,9 @@ var ValueSelector = { | |||
| case 'datetime-local': | |||
| // TODO | |||
| break; | |||
| case 'blur': | |||
| self.hide(); | |||
| break; | |||
There was a problem hiding this comment.
This change is not related right?
There was a problem hiding this comment.
(I'm not against it, just trying to understand)
There was a problem hiding this comment.
Hi, this is added to test another issue for "select based navigation".
Take MDN as an example,
https://developer.mozilla.org/en-US/
we have a element at the bottom of the page for language selection. If we select one of the languages with Gaia value selector, since the change would be triggered and cause the browser to reload. We would find that we could not receive a blur event to hide the value selector.
r=Vivien, a=blocking-basecamp
|
Merge this with r=Vivien, a=blocking-basecamp. |
RudyLu
added a commit
that referenced
this pull request
Nov 28, 2012
…achClick Bug 807418 - trigger change event for each click on the select option
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
value selector behavior change for,
Bug 807418 - [Clock] No way to preview an alarm tone