This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 809704 - [Dialer] can using headset button to answer/hangup the phone call #6644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| command: command | ||
| }; | ||
|
|
||
| callScreenWindow.postMessage(JSON.stringify(message), origin); |
There was a problem hiding this comment.
I'm pretty sure you can postMessage(message, origin) directly...
|
@etiennesegonzac the strings 'BT' and 'HS' are shouting to me to be added as constants, any suggestion where to put them? |
| if (telephony.active) { | ||
| end(); | ||
| } else { | ||
| answer(); |
There was a problem hiding this comment.
Maybe we should call |holdAndAnswer()| if handledCalls.length > 1 to handle multiple calls properly.
|
@etiennesegonzac comments added! |
| @command: The specific message to each kind of type | ||
| */ | ||
| function sendCommandToCallScreen(type, command) { | ||
| if (callScreenWindow == null) { |
There was a problem hiding this comment.
We can if (!callScreenWindow) here and remove it from the 2 handlers.
|
Latest comments (removing 2 checks) added bb+ r=@etiennesegonzac mergin \o/ |
arcturus
added a commit
that referenced
this pull request
Nov 28, 2012
Bug 809704 - [Dialer] can using headset button to answer/hangup the phone call
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a bit of refactoring in the postMessage to the callscreen to pass messages from bluetooth and headset
r=@etiennesegonzac