This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 821139 - Mirror latest gaia-ui-tests to gaia, r=lightsofapollo, a=te... #6988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,7 +65,8 @@ def test_call_contact(self): | |||
| self.wait_for_element_displayed(*self._outgoing_call_locator) | |||
|
|
|||
| # Check the number displayed is the one we dialed | |||
| self.assertEqual(self.contact['tel']['value'], | |||
| # TODO if this step fails bug 817291 may have been fixed | |||
| self.assertIn(self.contact['tel']['value'], | |||
| self.marionette.find_element(*self._calling_number_locator).text) | |||
There was a problem hiding this comment.
weird indentation I don't want to cause you more pain by fixing this kind of nit then needing to merge that back into the other repo but I had to say something :)
|
@jonallengriffin Looks good to me, I assume tests are OK I have not run them since the recent marionette changes. |
|
@lightsofapollo, we have some known failures noted with the 'xfail' attribute in the manifests. Would you prefer these not be merged in? |
|
No that is 100% fine with me merging. |
lightsofapollo
added a commit
that referenced
this pull request
Dec 13, 2012
Bug 821139 - Mirror latest gaia-ui-tests to gaia, r=lightsofapollo, a=te...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...st-only
JS files pass gjslint.