This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 797792 - [Clock] If next alarm comes more than 24 HOURS, it should display in DAYS instead of HOURS in countdown indicator #7750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of HOURS in countdown indicator.
| @@ -321,7 +328,6 @@ var AlarmList = { | |||
| handleEvent: function al_handleEvent(evt) { | |||
|
|
|||
| var link = evt.target; | |||
| var currentTarget = evt.currentTarget; | |||
There was a problem hiding this comment.
Looks like out of update. The line have been removed. You should rebase your patch to fix the conflict.
Conflicts: apps/clock/locales/clock.ar.properties
|
I updated the patch, it is ready to be reviewed now. |
|
r+, Thanks for Sergi's help. We can merge the pr now. |
|
@sergivila |
|
Please use PR at #7958. It has been squashed and should be ready to commit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug 797792.
This fix expresses the remaining time for the alarm to fire in days and hours only in cas that the remaining time is longer than 24 hours. I've added extra locale strings for
en-USandfr, butarandzh-TWshould be eventually completed.