Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Bug 830644 - [Settings] Support High resolution devices #8618

Merged
merged 2 commits into from Mar 20, 2013

Conversation

rexboy7
Copy link
Contributor

@rexboy7 rexboy7 commented Mar 13, 2013

tidied up from Ismael's repo.

@basiclines
Copy link
Contributor

Seem that apps/settings/style/images/radio_on.png assets are not anymore used in Settings app. Could we remove it?
It includes the off ones and their @2x versions.

}

/* secured networks */
.wifi-secure:after {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deletions were cause because of an old merge, if the deleted lines are the newer ones we should kept it. (I'm talking only about the small lock icon not about all the rules using background-positions these are ok)
Review it with any Settings owner plx!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked on the phone. Because in this patch the lock icon is put together with wifi signal sprites in one image, so I think this is no longer needed. I have checked it on the phone.. Will confirm with reviewer later if needed.

@rexboy7
Copy link
Contributor Author

rexboy7 commented Mar 14, 2013

radio_on and radio_off are removed now.

@basiclines
Copy link
Contributor

I've seen some issues in pairing window in settings:
Here is a patch for resolving it!

http://cl.ly/code/1A10291N2L3N

@rexboy7
Copy link
Contributor Author

rexboy7 commented Mar 18, 2013

@basiclines Oh I didn't notice that. Thanks for the patch! I'm now updating css of wifi signal, will update the PR soon.

@rexboy7
Copy link
Contributor Author

rexboy7 commented Mar 18, 2013

Updated by comments. Wifi signal and lock icon are now rendered separately, the same way as master branch.

@evelynhung May you review this PR? If you're busy on work week I can ask other owners. Thanks a lot!

rexboy7 added a commit that referenced this pull request Mar 20, 2013
Bug 830644 - [Settings][HIDPI] Support High resolution devices
@rexboy7 rexboy7 merged commit 7202403 into mozilla-b2g:master Mar 20, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants