Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

enable auto-correction #8962

Closed
wants to merge 2 commits into from
Closed

Conversation

andreasgal
Copy link
Contributor

Don't merge yet. Incomplete.

Issues:

  • disabling auto correct with a single backspace seems suboptimal (disables too easily)
  • prediction engine doesn't predict words where the first character is a near-hit (s -> a)

@andreasgal
Copy link
Contributor Author

@ckerschb @gregorwagner

@andreasgal
Copy link
Contributor Author

(feel free to steal, by the way)

@andreasgal
Copy link
Contributor Author

Before I forget, the other .dict files need to be re-created, too. I only updated en-US.

@andreasgal
Copy link
Contributor Author

I tried to investigate the issue why "s" is not predicted as "a", even though its a nearby key. I think this is some algorithmic problem in prediction.js. The new DAG code is sufficiently different from my bloom filter approach that I couldn't find a way to fix this. @ckerschb please help.

@davidflanagan
Copy link

As suggested above, I'm going to go ahead and steal this, and work on it under https://bugzilla.mozilla.org/show_bug.cgi?id=797170

I'll probably start a new pull request that borrows liberally from this one.

@mozilla-autolander-deprecated
Copy link
Contributor

This pull request has been closed due to tree stability issues. Please rebase and re-open the pull request if you still need to land this. Ensure the gaia-try run is green before landing. Sorry for any inconvenience.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants