This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1135821 - marionette-device-host 1.0.0 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
|
|
||
| '--restart': { | ||
| defaultValue: 1, |
There was a problem hiding this comment.
you could default these to the env vars if you care about backwards compat
|
aside from one optional comment above lgtm |
lambdabaa
changed the title
|
|
||
| return new Promise(function(accept, reject) { | ||
| proc.on('error', function(error) { | ||
| proc.removeListener('close', accept); |
There was a problem hiding this comment.
accept isn't bound to close below, so this won't really do anything.
lambdabaa
pushed a commit
that referenced
this pull request
Feb 24, 2015
Bug 1135821 - marionette-device-host 1.0.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.