Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Commit

Permalink
Merge pull request #6 from KevinGrandon/get_things_working_again
Browse files Browse the repository at this point in the history
Bug 940183 - Upgrade npm dependencies and use new interfaces r=gaye
  • Loading branch information
Gareth Aye committed Nov 20, 2013
2 parents 96b73bc + 1a965b9 commit 777cf83
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 14 deletions.
2 changes: 1 addition & 1 deletion Makefile
Expand Up @@ -5,7 +5,7 @@ MARIONETTE_MOCHA?=./node_modules/.bin/marionette-mocha \
default: node_modules lint test

firefox:
./node_modules/.bin/mozilla-download --product firefox --verbose $@
./node_modules/.bin/mozilla-download --product firefox --branch nightly --channel prerelease $@

node_modules:
npm install
Expand Down
22 changes: 15 additions & 7 deletions lib/host.js
Expand Up @@ -29,10 +29,10 @@ Host.DEFAULT_FIREFOX_RUNTIME = path.join(process.cwd(), 'firefox');


/**
* Default version of firefox to use.
* Default branch of firefox to use.
* @const {string}
*/
Host.DEFAULT_FIREFOX_VERSION = 'nightly';
Host.DEFAULT_FIREFOX_BRANCH = 'nightly';


/**
Expand Down Expand Up @@ -75,10 +75,17 @@ Host.prototype = {
this._options.runtime = Host.DEFAULT_FIREFOX_RUNTIME;
}

mozDownload.download(
if (!this._options.branch) {
this._options.branch = Host.DEFAULT_FIREFOX_BRANCH;
}

mozDownload(
'firefox',
this._options.runtime,
{ version: this._options.version },
{
channel: 'prerelease',
branch: this._options.branch,
product: 'firefox'
},
this._run.bind(this, profile, callback)
);
},
Expand Down Expand Up @@ -115,9 +122,10 @@ Host.prototype = {
}, 2000);
}).bind(this);

mozRunner.run('firefox', this._options.runtime, {
mozRunner.run('firefox', {
argv: ['-marionette'],
profile: profile
profile: profile,
product: 'firefox'
}, onChild);
}
};
12 changes: 6 additions & 6 deletions package.json
@@ -1,23 +1,23 @@
{
"name": "marionette-firefox-host",
"version": "0.0.1",
"version": "0.0.2",
"author": {
"name": "Gareth Aye",
"email": "gaye@mozilla.com"
},

"devDependencies": {
"empty-port": "0.0.1",
"marionette-client": "~0.12.0",
"marionette-client": "~1.1",
"mocha": "1.12.0",
"mozilla-profile-builder": "~0.2.0",
"marionette-js-runner": "~0.0.1",
"mozilla-profile-builder": "~0.3",
"marionette-js-runner": "~0.3",
"node-static": "0.6.9"
},

"dependencies": {
"mozilla-download": "0.2.1",
"mozilla-runner": "0.0.1",
"mozilla-download": "~0.4",
"mozilla-runner": "~0.2",
"remove": "0.1.5"
},

Expand Down

0 comments on commit 777cf83

Please sign in to comment.